Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: trigger conda-base update after augur release #1159

Closed
wants to merge 1 commit into from

Conversation

corneliusroemer
Copy link
Member

We currently only trigger a docker-base update.
There's no reason we shouldn't also trigger conda-base CI: https://github.com/nextstrain/conda-base/blob/main/.github/workflows/ci.yaml
The code here predates the existence of conda-base.

We currently only trigger a docker-base update.
There's no reason we shouldn't also trigger conda-base
The code here predates the existence of conda-base.
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 68.17% // Head: 68.17% // No change to project coverage 👍

Coverage data is based on head (4658ecb) compared to base (eef2a05).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          63       63           
  Lines        6752     6752           
  Branches     1654     1654           
=======================================
  Hits         4603     4603           
  Misses       1841     1841           
  Partials      308      308           
Impacted Files Coverage Δ
augur/__version__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not automated the trigger for conda-base because we need to wait for the Bioconda PR for Augur to be merged before we run the conda-base update.

Maybe we would check if Bioconda has uploaded the new version then trigger the conda-base update?

@corneliusroemer
Copy link
Member Author

Ah yes of course! Need to wait for bioconda.

Instead, we could just run bioconda ci daily?

@tsibley
Copy link
Member

tsibley commented Feb 28, 2023

nextstrain/conda-base#2 discusses this already.

@victorlin victorlin deleted the trigger-conda-base-post-release branch June 30, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants